[Property Editor] Display the name and documentation for the selected widget #8883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
requested review from
bkonyi and
kenzieschmoll
and removed request for
a team and
bkonyi
...evtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart
Outdated
Show resolved
Hide resolved
...ages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_view.dart
Outdated
Show resolved
Hide resolved
| ), | ||
| ], | ||
| ), | ||
| Row( |
There was a problem hiding this comment.
this should be in an expanded widget and the Column should have MainAxisSize.min
There was a problem hiding this comment.
Also, why do we need this row if there is only a single child?
There was a problem hiding this comment.
Added MainAxisSize.min, but without the row the text jumps to the left / right when the doc is collapsed / expanded
...ages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_view.dart
Outdated
Show resolved
Hide resolved
...ages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_view.dart
Outdated
Show resolved
Hide resolved
...ages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_view.dart
Outdated
Show resolved
Hide resolved
...ages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_view.dart
Outdated
Show resolved
Hide resolved
...ages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_view.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8716
Work towards #1948
Displays the name and documentation of the currently selected widget in the Property Editor.
If the widget has no editable properties, we still display the documentation: