Skip to content

[Widget Inspector] Update Select Widget Mode icon #9192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Widget Inspector] Update Select Widget Mode icon #9192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/devtools_app/lib/src/service/service_extensions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.

import 'package:devtools_app_shared/service_extensions.dart' as extensions;
import 'package:flutter/cupertino.dart' show CupertinoIcons;
import 'package:flutter/material.dart';

import '../shared/analytics/constants.dart' as gac;
Expand Down Expand Up @@ -445,7 +444,7 @@ final toggleOnDeviceWidgetInspector =
// toggling widget select mode as it is the only way to toggle that mode.
title: 'Select Widget Mode',
shortTitle: 'Select',
iconData: CupertinoIcons.cursor_rays,
iconData: const IconData(0x1F74A),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this in a named const so we can add dart doc to make it clear why we are using this icon and that we shouldn't change it?

gaScreenName: gac.inspector,
gaItem: gac.showOnDeviceInspector,
tooltip: 'Toggle select widget mode',
Expand All @@ -459,7 +458,7 @@ final toggleOnDeviceWidgetInspector =
final toggleSelectWidgetMode = ToggleableServiceExtensionDescription<bool>.from(
extensions.toggleSelectWidgetMode,
title: 'Select widget mode',
iconData: CupertinoIcons.cursor_rays,
iconData: const IconData(0x1F74A),
gaScreenName: gac.inspector,
gaItem: gac.selectWidgetMode,
tooltip: 'Toggle select widget mode',
Expand Down
6 changes: 3 additions & 3 deletions packages/devtools_app/macos/Runner.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
MACOSX_DEPLOYMENT_TARGET = 10.14;
MACOSX_DEPLOYMENT_TARGET = 10.15;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = macosx;
SWIFT_COMPILATION_MODE = wholemodule;
Expand Down Expand Up @@ -632,7 +632,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
MACOSX_DEPLOYMENT_TARGET = 10.14;
MACOSX_DEPLOYMENT_TARGET = 10.15;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
SDKROOT = macosx;
Expand Down Expand Up @@ -679,7 +679,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
MACOSX_DEPLOYMENT_TARGET = 10.14;
MACOSX_DEPLOYMENT_TARGET = 10.15;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = macosx;
SWIFT_COMPILATION_MODE = wholemodule;
Expand Down
1 change: 0 additions & 1 deletion packages/devtools_app/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ resolution: workspace
dependencies:
async: ^2.0.0
collection: ^1.15.0
cupertino_icons: ^1.0.0
dap: ^1.1.0
dds_service_extensions: ^2.0.0
devtools_app_shared:
Expand Down
Loading