[iOS] Fix view removal process for AutofillContextAction.cancel
#57209
Conversation
| @@ -2675,8 +2675,7 @@ - (void)hideTextInput { | |||
| [self removeEnableFlutterTextInputViewAccessibilityTimer]; | |||
| _activeView.accessibilityEnabled = NO; | |||
| [_activeView resignFirstResponder]; | |||
| [_activeView removeFromSuperview]; | |||
| [_inputHider removeFromSuperview]; | |||
| [self cleanUpViewHierarchy:YES clearText:NO delayRemoval:NO]; | |||
There was a problem hiding this comment.
Based on the comment here my assumption is that we should be setting clearText:YES in this case.
@LongCatIsLooong can you confirm?
There was a problem hiding this comment.
It's been a while since I looked at this. Is there a quick explanation of what is supposed to happen here? I think this will be called when the framework dismisses the software keyboard?
There was a problem hiding this comment.
It's not making a lot sense to me right now that cleanUpViewHierarchy needs to be called when the framework dismisses the keyboard. A bit explanation as to why the bug is happening (is the framework dismissing the keyboard before the autofill group cleans up the view hierarchy?)
There was a problem hiding this comment.
Hi @koji-1009 thanks for your contribution. To avoid a future regression, please add a test. If you need suggestions on how to write it or where it should be wired up, please let us know and we'll be glad to point you in the right direction! Take a look at shell/platform/darwin/ios/framework/Source/FlutterTextInputPluginTest.mm for examples.
|
@cbracken |
The
removeFromSuperviewin thehideTextInputmethod was triggering the save password, so I changed it tocleanUpViewHierarchy.fix flutter/flutter#145681
sample app code
https://github.com/koji-1009/autofill_cancel_issue
before
before.mp4
after
after.mp4
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.