Use new API for opening android module #8584
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
approved these changes
Oct 17, 2025
| if (target != null) { | ||
| GradleProjectImporter gradleImporter = GradleProjectImporter.getInstance(); | ||
| gradleImporter.importAndOpenProjectCore(null, true, projectFile); | ||
| com.intellij.ide.impl.ProjectUtil.openOrImport(projectFile.toNioPath(), OpenProjectTask.build().withForceOpenInNewFrame(forceOpenInNewFrame)); |
There was a problem hiding this comment.
I'd be inclined to replace this qualified name with an import statement? Or maybe there's some reason not to?
There was a problem hiding this comment.
After looking into this more, I think my solution is wrong because this method openOrImport is already being imported statically and is used below. There's some additional complexity here about whether a directory should be opened as though it's a project in itself or as a sub-project, but I'm not sure what all of the consequences are. I think I'll mark this PR a draft for now.
|
I haven't dug in but the new build failure seems surprising? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes #7599.
I checked that I can now use Tools > Flutter > Open Android module in Android Studio, and made sure this works with a new project and an existing project. There may be more testing needed, e.g. is this supposed to work in IntelliJ also?
If we want to use this again, we should probably also re-enable a menu when a user right clicks the android subdirectory, and update comments related to dd5a521