[video_player] Add html 5 video poster support (thumbnail) as a VideoPlayerWebOptions #8940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ortes
requested review from
hellohuanlin,
camsim99 and
matanlurey
as code owners
Ortes
force-pushed
the
video-player-html-poster-support
branch
from
713c652 to
d529939
Compare
Ortes
force-pushed
the
video-player-html-poster-support
branch
from
d529939 to
b43bf65
Compare
Ortes
force-pushed
the
video-player-html-poster-support
branch
2 times, most recently
from
2b124fe to
71ea426
Compare
Ortes
changed the title
Closed
11 tasks
|
Where is the combination PR for initial review that this was split from (per the documented process)? |
Ortes
force-pushed
the
video-player-html-poster-support
branch
from
c3d02e8 to
eb0d4b7
Compare
github-actions
bot
added
platform-android
platform-ios
platform-macos
platform-web
labels
Draft
11 tasks
Ortes
changed the title
Ortes
force-pushed
the
video-player-html-poster-support
branch
from
eb0d4b7 to
0eaff0f
Compare
Is this ok like this ? here is the PR for platform_interface |
stuartmorgan-g
added
the
federated: all_changes
Ortes
force-pushed
the
video-player-html-poster-support
branch
4 times, most recently
from
8db4982 to
691d64f
Compare
Ortes
force-pushed
the
video-player-html-poster-support
branch
from
691d64f to
6db1d9c
Compare
|
From triage: @tarrinneal This should be ready for initial review. |
tarrinneal
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
posterattribute on web by introducing aposterfield inVideoPlayerWebOptions. It allows setting a thumbnail image for videos using the native HTML5posterproperty, improving the out-of-the-box web experience.Solve this issue:
flutter/flutter#166232
Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3