[go_router] Fix replace routes hanging the originating completer #9332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nouvist LGTM, thank you for submitting the fix, I was facing the same issue |
chunhtai
reviewed
Jun 2, 2025
| @@ -168,6 +168,18 @@ class GoRouteInformationParser extends RouteInformationParser<RouteMatchList> { | |||
| return redirectedFuture; | |||
| } | |||
|
|
|||
| /// Ensures the replacement routes can resolve the originating route completer. | |||
| Completer<T?>? _createInheritedCompleter<T>( | |||
There was a problem hiding this comment.
What if the type T mismatched for the new route and the old route. Instead of inherited the completer, I think it should resolve the previous route's future because it is replaced.
There was a problem hiding this comment.
Yeah, that's the problem, but I still think resolve the completer when the replacement pops up is my preferred, as the waiting route can hold until its screen reappears.
I propose, what if the push (etc) had a mapReplacementResult? But it may need to be on RouteInformationState and ImperativeRouteMatch, which I'm not sure if there will be breaking changes or not.
nouvist
force-pushed
the
fix-hangs
branch
5 times, most recently
from
fbe167b to
f8f51c6
Compare
Both are used to resolve the current route completer when it is replaced. Both are added to `RouteInformationState` and `ImperativeRouteMatch`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
replaceandpushReplacementinvolves popping the last route and ignoring the completer, leaving the last route's future unresolved. This PR introduces new behavior for both methods to inherit the last route's completer if the last route is anImperativeRouteMatch.Expected issue(s) should be fixed by this:
GoRoute.push()is not resolving when the push page gets replaced via pushReplacement flutter#141251Previous behavior:
sebelum.mp4
This PR behavior:
sesudah.mp4
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3