Skip to content

[WIP][camera_android_camerax] Force new Surface for each SurfaceRequest #9360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP][camera_android_camerax] Force new Surface for each SurfaceRequest #9360

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47cee97
logging for debugging
camsim99 May 29, 2025
c73110f
debugging logging pt 2
camsim99 May 29, 2025
44aa92a
Merge remote-tracking branch 'upstream/main' into abandon_2
camsim99 Jun 2, 2025
8d5223d
remove logs and add comment
camsim99 Jun 2, 2025
0b4dfa0
update wip
camsim99 Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...era_android_camerax/android/src/main/java/io/flutter/plugins/camerax/PreviewProxyApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,16 @@ public void onSurfaceCleanup() {
// Provide surface.
surfaceProducer.setSize(
request.getResolution().getWidth(), request.getResolution().getHeight());
Surface flutterSurface = surfaceProducer.getSurface();
Surface flutterSurface = surfaceProducer.getSurface(true);
request.provideSurface(
flutterSurface,
Executors.newSingleThreadExecutor(),
(result) -> {
// RACE CONDITION EXPLANATION for https://github.com/flutter/flutter/pull/169899:
// Sometimes, this callback is called after the next SurfaceRequest comes in,
// making a call on line 122 to get a `Surface`, which is the same `Surface` that was (potentially)
// successfully used and should not be re-used.
//
// See
// https://developer.android.com/reference/androidx/camera/core/SurfaceRequest.Result
// for documentation.
Expand Down