[google_maps_flutter_platform_interface] Add Advanced markers support #9737
+821
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for Advanced Markers in the google_maps_flutter platform interface. The changes include adding a new AdvancedMarker class, PinConfig for custom marker appearances, and related enums and helper classes. The MapConfiguration is updated to handle marker types and to deprecate cloudMapId in favor of mapId. The changes are well-tested.
stuartmorgan-g
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
LGTM with CHANGELOG fix
@bparrishMines for secondary review
packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
stuartmorgan-g
added
the
federated: partial_changes
bparrishMines
added
the
autosubmit
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 8, 2025
flutter/packages@6efb759...34948d1 2025-08-07 [email protected] [video_player] Improve KVO handling on iOS (flutter/packages#9718) 2025-08-07 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 15 directories with 7 updates (flutter/packages#9736) 2025-08-07 [email protected] Roll Flutter from 9de63a0 to 92a6bfb (11 revisions) (flutter/packages#9769) 2025-08-07 [email protected] [google_maps_flutter_platform_interface] Add Advanced markers support (flutter/packages#9737) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 11, 2025
…r#173470) flutter/packages@6efb759...34948d1 2025-08-07 [email protected] [video_player] Improve KVO handling on iOS (flutter/packages#9718) 2025-08-07 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 15 directories with 7 updates (flutter/packages#9736) 2025-08-07 [email protected] Roll Flutter from 9de63a0 to 92a6bfb (11 revisions) (flutter/packages#9769) 2025-08-07 [email protected] [google_maps_flutter_platform_interface] Add Advanced markers support (flutter/packages#9737) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Advanced markers support to the platform interface of
google_maps_flutter.Approved combined PR: #7882
Issue: #155526
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3