[ci] Exclude packages using deprecated APIs from the pod linter check #9746
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to unblock CI on Xcode 26 by excluding packages with known deprecation warnings from the podspec-check. The change is well-reasoned and uses a separate configuration file for the exclusion list, which is good practice. My review includes one suggestion to improve the readability and robustness of the command-line arguments in the CI configuration file.
Draft
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 6, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 6, 2025
flutter/packages@83ae18a...f0b2726 2025-08-06 [email protected] [local_auth] Differentiate iOS authentication errors (flutter/packages#9705) 2025-08-06 [email protected] manual roll to 59fc766 (flutter/packages#9758) 2025-08-05 [email protected] [ci] Exclude packages using deprecated APIs from the pod linter check (flutter/packages#9746) 2025-08-05 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.5.1 to 8.11.1 in /packages/file_selector/file_selector_android/android (flutter/packages#9621) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 26 is showing deprecation usage as warnings: flutter/flutter#170437. These warnings are causing
podspec-checkto fail as these warnings are being treated as errors.To unblock testing Xcode 26 in CI, exclude the existing
exclude_xcode_deprecationpackages from the podspec check command.Currently used here:
packages/.ci/targets/ios_platform_tests.yaml
Line 21 in 83ae18a
packages/.ci/targets/macos_platform_tests.yaml
Line 18 in 83ae18a
This isn't a perfect solution, as the podspec check will find more issues than just deprecation warnings (Swift 6 warnings, for example), and this will prevent any warnings being discovered for these packages. However, I believe it's a better solution than #9428 (not treating warnings as errors for any package) because NEW regression warnings in all other packages can be caught in presubmit.
Closes #9428
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3