-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart fix --apply
from Flutter 3.21.0-1.0.pre.2
#2220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response. I was OOO last week. LGTM! For the deprecated colors, I think we can just remove the corresponding ColorChip
s. Leaving them here for now is also okay because I will update this ColorScheme page soon to add all the new colors and remove the deprecated colors (If they are still here:)).
@@ -303,13 +303,13 @@ class ColorSchemeView extends StatelessWidget { | |||
children: [ | |||
ColorChip( | |||
label: 'background', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can actually remove these chips whose colors have been deprecated:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to adopt this change and adapt it to suit your needs. I was just getting in early to see what the required changes for the next stable release might look like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed a small change to remove the deprecated color chips! :)
@@ -251,13 +251,13 @@ class ColorSchemeView extends StatelessWidget { | |||
), | |||
ColorChip( | |||
label: 'surfaceVariant', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here, I think we can remove this:)
Replaced by #2266 |
Hey @QuncCccccc, any views on the fixes suggested by
dart fix
?This PR needs to be held for the next stable update.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.