Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for DevTools extensions #10061

Merged
merged 9 commits into from
Jan 18, 2024
Merged

Add documentation for DevTools extensions #10061

merged 9 commits into from
Jan 18, 2024

Conversation

kenzieschmoll
Copy link
Member

@kenzieschmoll kenzieschmoll commented Jan 17, 2024

These docs will be linked to from the devtools_options.yaml file that DevTools creates for storing extension enablement states: flutter/devtools#7052

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jan 17, 2024

Visit the preview URL for this PR (updated for commit 3505713):

https://flutter-docs-prod--pr10061-dte-g65447sq.web.app

@parlough parlough added the review.copy Awaiting Copy Review label Jan 17, 2024
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After incorporating feedback, lgtm

src/tools/devtools/extensions.md Outdated Show resolved Hide resolved
src/tools/devtools/extensions.md Outdated Show resolved Hide resolved

![Screenshot of extension enablement prompt]({{site.url}}/assets/images/docs/tools/devtools/extension_enable_prompt.png)

### devtools_options.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### devtools_options.yaml
## Configure extensions file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "Extension enablement states"? This may not always be an extensions only file and the user shouldn't need to manually configure this. This doc is supposed to be an explanation of why a devtools_options.yaml file is showing up in the user's project and what they should do with it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Configure extension enablement states" ok? I'm trying to keep the headers parallel, in the sense that we try to start each header with a (non-gerund) verb. But if it's really not working for you, I can be flexible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used "Configure extension enablement states" and moved the screenshot and explanation of how to enable the extension from devtools to this section. I think this makes it more clear that you should be enabling and disabling extensions from DevTools, and that the file is just to persist this data.

src/tools/devtools/extensions.md Outdated Show resolved Hide resolved
src/tools/devtools/extensions.md Outdated Show resolved Hide resolved
src/tools/devtools/extensions.md Outdated Show resolved Hide resolved
src/tools/devtools/extensions.md Outdated Show resolved Hide resolved
kenzieschmoll and others added 4 commits January 18, 2024 11:44
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
@parlough parlough added review.await-update Awaiting Updates after Edits and removed review.copy Awaiting Copy Review labels Jan 18, 2024
@parlough parlough assigned kenzieschmoll and unassigned sfshaza2 Jan 18, 2024
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kenzieschmoll! Let's ship it so you can land your DevTools PR. I imagine we can expand this further in the future (including incorporating the relevant content from the blog post), as we better understand how users are using and building extensions.

@kenzieschmoll kenzieschmoll merged commit ec6dd6d into main Jan 18, 2024
9 checks passed
@parlough parlough removed the review.await-update Awaiting Updates after Edits label Jan 19, 2024
atsansone pushed a commit to atsansone/website that referenced this pull request Jan 24, 2024
These docs will be linked to from the `devtools_options.yaml` file that
DevTools creates for storing extension enablement states:
flutter/devtools#7052

---------

Co-authored-by: Brett Morgan <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
atsansone pushed a commit to atsansone/website that referenced this pull request Apr 5, 2024
These docs will be linked to from the `devtools_options.yaml` file that
DevTools creates for storing extension enablement states:
flutter/devtools#7052

---------

Co-authored-by: Brett Morgan <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants