-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting of code snippets on iOS dev pages #11021
Conversation
Visit the preview URL for this PR (updated for commit 8572493): https://flutter-docs-prod--pr11021-fix-10725-yh3wme43.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for thinking about improving this!
For some reason it's not triggering, but CI is supposed to include a formatting check against these files with dart format
. Running dart format
will revert many of these changes. I'll work on fixing that check. (Edit: #11027)
What do you think about instead moving the docregion
comments above the previous line (like child: ...
)? It will end up showing some extra information, but I think that's okay considering the examples. We can remove those properties with other code excerpt functionality if needed as well.
I dare not insert myself here. When you are back, @parlough, can you address this one? |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it lgt @domesticmouse, it looks good to me.
hey sry, i missed this. when i tried to run some excerpter generation command locally i got an error. that's what i remember last. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey sry, i missed this. when i tried to run some excerpter generation command locally i got an error. that's what i remember last.
No worries! I went ahead and moved the comments and added replacement instructions for the code excerpt tool. You can check out the commit 9346457 to see what I did.
As for the error, let me know if you hit it again and I'd be happy to fix it or work through a solution with you.
Thanks again for doing this!!
Fix Formatting.
Fixes #10725
Presubmit checklist