[Swift Package Manager] Update docs after 3.24 release #11071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
sfshaza2,
parlough and
a team
as code owners
loic-sharma
commented
Aug 21, 2024
| @@ -25,9 +25,11 @@ Using the Flutter CLI to run an app [migrates the project][addSPM] to add | |||
| Swift Package Manager integration. | |||
| This makes your project download the Swift packages that | |||
| your Flutter plugins depend on. | |||
| If you disable the Swift Package Manager feature, | |||
| you will need to [remove Swift Package Manager integration][removeSPM] from apps | |||
| that are migrated. | |||
There was a problem hiding this comment.
The previous statement was incorrect. You had to undo the integration if you switched to the stable branch (which also implicitly disables the SPM feature). If you disabled the SPM feature but stayed on the master channel, the app would continue to build fine. I had misunderstood how this worked!
|
Visit the preview URL for this PR (updated for commit 6be62c1): https://flutter-docs-prod--pr11071-spm-flutter-3-24-pqg90v64.web.app |
loic-sharma
commented
Aug 21, 2024
| @@ -440,8 +440,8 @@ The example below uses `ios`, replace `ios` with `macos`/`darwin` as applicable. | |||
|
|
|||
| **Do not commit the migration's changes to your version control system.** | |||
There was a problem hiding this comment.
FYI, I kept this recommendation to not check-in the SPM integration for your example app. This ensures customers using Flutter version lower than 3.24 can continue to build the example app.
jmagman
approved these changes
Aug 21, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to Flutter 3.24, a Flutter app that was migrated to have Swift Package Manager integration could not be built on the stable branch.
With Flutter 3.24, the app will now build successfully. However, plugins will continue to be installed using CocoaPods as the SwiftPM feature remains unavailable on the stable channel.
Issues fixed by this PR (if any): flutter/flutter#153448
PRs or commits this PR depends on (if any):
Presubmit checklist