Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headers and toc duplication in widget catalog #11121

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

parlough
Copy link
Member

Headers weren't being modified by our 11ty/markdown to add anchors, so this PR switches them to use Markdown and enable the automatic processing.

The pages also had duplicate TOCS, one manual and another automatically generated. This PR removes the manual one to standardize with the rest of the site.

Also slightly improves the rendering on the catalog pages with only one or two entries in a subcategory.

Contributes to #10525 and makes future site redesign changes easier

@parlough parlough requested review from sfshaza2 and a team as code owners September 10, 2024 20:15
@parlough parlough requested review from MaryaBelanger and removed request for MaryaBelanger September 10, 2024 20:15
@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 7e5830c):

https://flutter-docs-prod--pr11121-fix-widget-catalog-headers-rd8t5dtn.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 0cb37db into main Sep 11, 2024
9 checks passed
@sfshaza2 sfshaza2 deleted the fix/widget-catalog-headers branch September 11, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants