Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds note about color equality after wide gamut. #11132

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Sep 12, 2024

Description of what this PR is changing or adding, and why:

Adding more details about the changing of Color equality.

Issues fixed by this PR (if any):

flutter/flutter#127855

PRs or commits this PR depends on (if any):

flutter/engine#54981

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@gaaclarke gaaclarke requested review from sfshaza2, parlough and a team as code owners September 12, 2024 21:37
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Sep 12, 2024

Visit the preview URL for this PR (updated for commit f2ff5d0):

https://flutter-docs-prod--pr11132-color-equality-fllpngpb.web.app

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, this answers a question on a cocoon PR flutter/cocoon#3902 (comment)

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@gaaclarke gaaclarke merged commit 3665cfb into flutter:main Sep 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants