Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect deprecation of the HTML renderer on image CORS details #11155

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Reflect deprecation of the HTML renderer on image CORS details #11155

merged 4 commits into from
Sep 23, 2024

Conversation

JaffaKetchup
Copy link
Contributor

Description of what this PR is changing or adding, and why:

Removes references to the HTML renderer (as it is being deprecated), except for a small version note. Re-organised the page to better show the reduced information load and remove redundant headings.

I believe this comes into effect with 3.25.0, at the same time as flutter/flutter#152683 is released, but #11045 has already been made, so this PR may be suitable immediately.

_Issues fixed by this PR (if any): #11154

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@JaffaKetchup JaffaKetchup requested review from sfshaza2, parlough and a team as code owners September 17, 2024 19:16
@JaffaKetchup JaffaKetchup changed the title Reflect deprecation of the HTML renderer Reflect deprecation of the HTML renderer on image CORS details Sep 17, 2024
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoothed out a sentence that was a bit hard to parse. Otherwise, LGTM. Thx!

@sfshaza2
Copy link
Contributor

/gcbrun

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Sep 18, 2024

Visit the preview URL for this PR (updated for commit b928612):

https://flutter-docs-prod--pr11155-patch-2-yv7nxh1f.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for these adjustments!

I expect more changes will be needed in the future with Harry's work on flutter/flutter#149843, but it's nice to see some simplification to the docs in the mean time :D

src/content/platform-integration/web/web-images.md Outdated Show resolved Hide resolved
@parlough
Copy link
Member

/gcbrun

@parlough parlough merged commit 21ae949 into flutter:main Sep 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants