-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect deprecation of the HTML renderer on image CORS details #11155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoothed out a sentence that was a bit hard to parse. Otherwise, LGTM. Thx!
/gcbrun |
Visit the preview URL for this PR (updated for commit b928612): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for these adjustments!
I expect more changes will be needed in the future with Harry's work on flutter/flutter#149843, but it's nice to see some simplification to the docs in the mean time :D
/gcbrun |
Description of what this PR is changing or adding, and why:
Removes references to the HTML renderer (as it is being deprecated), except for a small version note. Re-organised the page to better show the reduced information load and remove redundant headings.
I believe this comes into effect with 3.25.0, at the same time as flutter/flutter#152683 is released, but #11045 has already been made, so this PR may be suitable immediately.
_Issues fixed by this PR (if any): #11154
Presubmit checklist