Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify notice about installation in China #11167

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented Sep 21, 2024

Clarify that the note is not meant to be for each country, but rather specifically for China.

Also add Chinese instructions to better catch the attention of Chinese readers.

Resolves #11158
Resolves #11166

Staged: https://flutter-docs-prod--pr11167-fix-clarify-china-notice-q4g69pok.web.app/get-started/install/

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Sep 21, 2024

Visit the preview URL for this PR (updated for commit 18d657c):

https://flutter-docs-prod--pr11167-fix-clarify-china-notice-q4g69pok.web.app

@parlough parlough marked this pull request as ready for review September 21, 2024 23:45
@parlough parlough requested review from sfshaza2 and a team as code owners September 21, 2024 23:45
@parlough parlough requested review from domesticmouse and removed request for domesticmouse September 21, 2024 23:45
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice to include the note in Chinese! Thanks, @parlough, for learning Mandarin!

@sfshaza2 sfshaza2 merged commit 756ce57 into main Sep 25, 2024
9 checks passed
@sfshaza2 sfshaza2 deleted the fix/clarify-china-notice branch September 25, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Big Problem I'm not in China
4 participants