-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Missing note: The file should be recompiled using Visual Studio for the changes to take effect #11391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbdeMohlbi, thanks very much for this great contribution! I made a few style changes, but otherwise, LGTM
/gcbrun |
Visit the preview URL for this PR (updated for commit 07b533a): |
Hey @sfshaza2, thanks for your attention! What concerns me is the error message that mentions a "memory leak." I tried debugging but couldn't find any leak. Is this expected? |
@DanTup, do you have any idea of this error message might be an actual leak? |
I'm afraid I don't know - I'm not very familiar with C++ and I don't know where this message might be coming from. It does seem like an odd error if the issue is just that the code hasn't been recompiled though (and I'm also unsure whether it should be required to manually compile, or if |
Thanks, @DanTup! @stuartmorgan, can you weigh in? |
I just left a comment in the issue; we should not be telling people they have to rebuild from within Visual Studio. |
:::note | ||
To ensure that the changes take effect, recompile the project. | ||
Otherwise, you might encounter the following error: **Failed to get | ||
battery level: Memory leak.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how it's possible to get this error message string from the provided example code, so this needs further debugging with repro steps; changing docs is premature (especially since the step the new text is recommending should not be necessary).
Thanks so much, @stuartmorgan! @AbdeMohlbi, I'm going to close this issue for now. Good luck debugging this! |
fixes: #11390
Presubmit checklist