Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Missing note: The file should be recompiled using Visual Studio for the changes to take effect #11391

Closed
wants to merge 2 commits into from

Conversation

AbdeMohlbi
Copy link

@AbdeMohlbi AbdeMohlbi commented Nov 12, 2024

fixes: #11390

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbdeMohlbi, thanks very much for this great contribution! I made a few style changes, but otherwise, LGTM

@sfshaza2
Copy link
Contributor

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 07b533a):

https://flutter-docs-prod--pr11391-patch-1-b6p9uoae.web.app

@AbdeMohlbi
Copy link
Author

AbdeMohlbi commented Nov 13, 2024

@AbdeMohlbi, thanks very much for this great contribution! I made a few style changes, but otherwise, LGTM

Hey @sfshaza2, thanks for your attention!

What concerns me is the error message that mentions a "memory leak." I tried debugging but couldn't find any leak. Is this expected?
Also i prefer to mention visual studio so devs won't try to recompile the project on there ide ( AS,intellij,vsCode).

@AbdeMohlbi AbdeMohlbi marked this pull request as ready for review November 13, 2024 18:14
@AbdeMohlbi AbdeMohlbi requested review from parlough and a team as code owners November 13, 2024 18:14
@AbdeMohlbi AbdeMohlbi changed the title add Missing note: The file should be compiled using Visual Studio for the changes to take effect add Missing note: The file should be recompiled using Visual Studio for the changes to take effect Nov 13, 2024
@sfshaza2
Copy link
Contributor

@DanTup, do you have any idea of this error message might be an actual leak?

@DanTup
Copy link
Contributor

DanTup commented Nov 18, 2024

I'm afraid I don't know - I'm not very familiar with C++ and I don't know where this message might be coming from.

It does seem like an odd error if the issue is just that the code hasn't been recompiled though (and I'm also unsure whether it should be required to manually compile, or if flutter run should be doing it automatically?).. It could be worth someone more familiar with the Visual Studio / C++ parts to weigh in on this. (@stuartmorgan looks like you may have added some of this code, so maybe you have some ideas/opinion on this?)

@sfshaza2
Copy link
Contributor

Thanks, @DanTup!

@stuartmorgan, can you weigh in?

@stuartmorgan
Copy link
Contributor

I just left a comment in the issue; we should not be telling people they have to rebuild from within Visual Studio. flutter run will rebuild native code.

:::note
To ensure that the changes take effect, recompile the project.
Otherwise, you might encounter the following error: **Failed to get
battery level: Memory leak.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how it's possible to get this error message string from the provided example code, so this needs further debugging with repro steps; changing docs is premature (especially since the step the new text is recommending should not be necessary).

@sfshaza2
Copy link
Contributor

Thanks so much, @stuartmorgan! @AbdeMohlbi, I'm going to close this issue for now. Good luck debugging this!

@sfshaza2 sfshaza2 closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing note: The file should be recompiled using Visual Studio for the changes to take effect.
5 participants