Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration Guide for Updated Material 3 Progress Indicators #11396

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Migration Guide for Updated Material 3 Progress Indicators #11396

merged 1 commit into from
Nov 20, 2024

Conversation

TahaTesser
Copy link
Member

Related to Update Material 3 CircularProgressIndicator for new visual style and Update Material 3 LinearProgressIndicator for new visual style

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Nov 14, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 53e8a3e):

https://flutter-docs-prod--pr11396-progress-indicators-migrati-ieojmrlv.web.app

@TahaTesser TahaTesser force-pushed the progress_indicators_migration_guide branch from ad09637 to 80da711 Compare November 18, 2024 11:35
@TahaTesser TahaTesser force-pushed the progress_indicators_migration_guide branch from 80da711 to 53e8a3e Compare November 18, 2024 11:46
@TahaTesser TahaTesser marked this pull request as ready for review November 20, 2024 10:04
@TahaTesser TahaTesser requested review from sfshaza2, parlough and a team as code owners November 20, 2024 10:04
@TahaTesser TahaTesser requested a review from Piinks November 20, 2024 10:04
@TahaTesser
Copy link
Member Author

flutter/flutter#158104 and flutter/flutter#154817 have landed. As a result, this guide is ready to review.

sfshaza2
sfshaza2 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, @TahaTesser! lgtm

@sfshaza2 sfshaza2 merged commit 085b21a into flutter:main Nov 20, 2024
9 checks passed
@TahaTesser TahaTesser deleted the progress_indicators_migration_guide branch November 20, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@parlough parlough Awaiting requested review from parlough parlough is a code owner

@Piinks Piinks Awaiting requested review from Piinks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TahaTesser @flutter-website-bot @sfshaza2