Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValueNotifier example in state-management.md #11553

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

GIT-chandra
Copy link
Contributor

@GIT-chandra GIT-chandra commented Dec 27, 2024

"value" and "child" were swapped in the ValueWidgetBuilder function

Description of what this PR is changing or adding, and why: This is a correction in the order of parameters passed to a function, in the ValueNotifier usage example.

Issues fixed by this PR (if any):
Screenshot 2024-12-27 223344

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

"value" and "child" were wrongly swapped in the ValueWidgetBuilder function
@GIT-chandra GIT-chandra requested review from sfshaza2, parlough and a team as code owners December 27, 2024 17:08
Copy link

google-cla bot commented Dec 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@parlough
Copy link
Member

parlough commented Jan 1, 2025

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 9f7b997):

https://flutter-docs-prod--pr11553-patch-1-r8uljyo7.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for fixing this :)

@parlough parlough merged commit 605f81f into flutter:main Jan 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants