-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sliverappbar stretch effect #73
base: master
Are you sure you want to change the base?
Sliverappbar stretch effect #73
Conversation
…t, which is not supported by offical NestedScrollView yet
@@ -723,7 +730,8 @@ class _NestedScrollCoordinator | |||
} | |||
} | |||
|
|||
if (innerPosition == null) { | |||
// Kenshin: if innser scrollview is scrolled beyond top, change _outerPosition only | |||
if (innerPosition == null || (_stretchHeaderSlivers && innerPosition.pixels == 0.0)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be innerPosition.pixels <= 0.0, if use equal, sometimes, inner scrollview is not scroll to top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Hi I used your commit. When I use stretch I get errors like these:
Are there any solutions? |
你的代码已经报错了, 需要改一下才能运行, 这样是不能合并的. |
Does anyone follow this PR or this problem anymore? If you've found a solution, what was it? |
i'm waiting an official pr, if you have a good idea, you can push a pr to flutter team. i must make sure the codes will not breaking any other function |
I understand. My question was regarding this problem with the outer body overscrolling/stretching at the top (for refresh effect similar to popular social media apps) and load more effect with the bottom (i can actually achieve this one myself using the infinite_scroll_pagination package). Could not achieve a proper refresh effect so far. |
I'm trying to simulate the app bar large title stretch effect in iOS, it would be great if we could especially fix the 2nd problem and add this as a feature for this package. @zmtzawqlp |
Fixes issue: Unable to stretch SliverAppBar issue
This is a quick hack, optimal effect requires extensive refactoring, thus official Flutter team is not picking up this issue. Some limitations apply:
BouncingScrollPhysics
, when the SliverAppBar background stretches, so does the body scroll view.See scroll to top demo to have a play.