Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix invalid linter #502

Merged
merged 1 commit into from
Oct 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
🐛 Fix invalid linter
AmosHuKe committed Oct 25, 2023
commit 81de0f71ca11a524a38e6194cbb40291bd58ca75
2 changes: 1 addition & 1 deletion analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
includes: package:flutter_lints/flutter.yaml
include: package:flutter_lints/flutter.yaml

linter:
rules:
1 change: 1 addition & 0 deletions example/lib/customs/pickers/insta_asset_picker.dart
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@
///
/// See the package https://github.com/LeGoffMael/insta_assets_picker
/// for the complete implementations.
library;

import 'dart:math';

10 changes: 5 additions & 5 deletions lib/src/delegates/asset_picker_builder_delegate.dart
Original file line number Diff line number Diff line change
@@ -1707,7 +1707,7 @@ class DefaultAssetPickerBuilderDelegate

@override
Widget pathEntitySelector(BuildContext context) {
Widget _text(
Widget pathText(
BuildContext context,
String text,
String semanticsText,
@@ -1758,13 +1758,13 @@ class DefaultAssetPickerBuilderDelegate
mainAxisSize: MainAxisSize.min,
children: <Widget>[
if (path == null && isPermissionLimited)
_text(
pathText(
context,
textDelegate.changeAccessibleLimitedAssets,
semanticsTextDelegate.changeAccessibleLimitedAssets,
),
if (path != null)
_text(
pathText(
context,
isPermissionLimited && path.isAll
? textDelegate.accessiblePathName
@@ -1924,7 +1924,7 @@ class DefaultAssetPickerBuilderDelegate

@override
Widget previewButton(BuildContext context) {
Future<void> _onTap() async {
Future<void> onTap() async {
final DefaultAssetPickerProvider p =
context.read<DefaultAssetPickerProvider>();
final List<AssetEntity> selectedAssets = p.selectedAssets;
@@ -1966,7 +1966,7 @@ class DefaultAssetPickerBuilderDelegate
},
child: Consumer<DefaultAssetPickerProvider>(
builder: (_, DefaultAssetPickerProvider p, __) => GestureDetector(
onTap: p.isSelectedNotEmpty ? _onTap : null,
onTap: p.isSelectedNotEmpty ? onTap : null,
child: Selector<DefaultAssetPickerProvider, String>(
selector: (_, DefaultAssetPickerProvider p) =>
p.selectedDescriptions,
3 changes: 2 additions & 1 deletion test/test_utils.dart
Original file line number Diff line number Diff line change
@@ -44,7 +44,8 @@ Widget defaultPickerTestApp({
}

class _DefaultHomePage extends StatelessWidget {
const _DefaultHomePage(this.onButtonPressed, {Key? key}) : super(key: key);
// ignore: unused_element
const _DefaultHomePage(this.onButtonPressed, {super.key});

final void Function(BuildContext)? onButtonPressed;