kvs: remove stats clearing #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chu11
force-pushed
the
issue6607_kvs_stats_clear_remove
branch
2 times, most recently
from
399334e to
2687ac6
Compare
Problem: Some out of date comments were left over and never removed in the event_subscribe() function. Remove the out of date comments.
Problem: KVS stats clearing code was added very early on in KVS prototyping for testing. It is basically not used anymore. If we want to test something that requires a "clean" slate for the KVS, we can just start a new instance and test with that. Solution: Remove all KVS stats clearing code. Remove all associated tests. Fixes flux-framework#6607
chu11
force-pushed
the
issue6607_kvs_stats_clear_remove
branch
from
2687ac6 to
df1c9b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6611 +/- ##
==========================================
- Coverage 83.86% 83.84% -0.03%
==========================================
Files 534 534
Lines 88381 88358 -23
==========================================
- Hits 74124 74086 -38
- Misses 14257 14272 +15
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: KVS stats clearing code was added very early on in KVS prototyping for testing. It is basically not used anymore. If we
want to test something that requires a "clean" slate for the KVS, we can just start a new instance and test with that.
Solution: Remove all KVS stats clearing code. Remove all associated tests.
Fixes #6607