-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add development environment #1045
Add development environment #1045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, though I don't know how to test it. Might want to get @trws or @jameshcorbett approval as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried it out but it looks reasonable!
Problem: we do not yet have a developer environment for Flux sched. More specifically, to easily test the go bindings without needing to build a container, it would be nice to have this. Solution: Add a .devcontainer setup to flux-sched Signed-off-by: vsoch <[email protected]>
885c007
to
e795e49
Compare
go go rebase go!!! |
Codecov Report
@@ Coverage Diff @@
## master #1045 +/- ##
========================================
- Coverage 74.4% 74.4% -0.1%
========================================
Files 86 86
Lines 9434 9434
========================================
- Hits 7022 7019 -3
- Misses 2412 2415 +3 |
woo! Thanks everyone! |
Problem: We do not yet have a developer environment for flux-sched. More specifically, to easily test the go bindings without needing to build a container, it would be nice to have this. I'm anticipating helping with #1008 and this would be super to have, so I've added an install of go 1.19 to the container.
Solution: Add a .devcontainer setup to flux-sched!