Add development environment #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grondo
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Seems fine to me, though I don't know how to test it. Might want to get @trws or @jameshcorbett approval as well.
jameshcorbett
approved these changes
Jul 18, 2023
trws
approved these changes
Jul 18, 2023
vsoch
added
the
merge-when-passing
Problem: we do not yet have a developer environment for Flux sched. More specifically, to easily test the go bindings without needing to build a container, it would be nice to have this. Solution: Add a .devcontainer setup to flux-sched Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
add/devcontainer-with-go
branch
from
885c007
to
e795e49
Compare
|
go go rebase go!!! |
Codecov Report
@@ Coverage Diff @@
## master #1045 +/- ##
========================================
- Coverage 74.4% 74.4% -0.1%
========================================
Files 86 86
Lines 9434 9434
========================================
- Hits 7022 7019 -3
- Misses 2412 2415 +3 |
|
woo! Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We do not yet have a developer environment for flux-sched. More specifically, to easily test the go bindings without needing to build a container, it would be nice to have this. I'm anticipating helping with #1008 and this would be super to have, so I've added an install of go 1.19 to the container.
Solution: Add a .devcontainer setup to flux-sched!