testsuite: t1024-alloc-check.t: do not fail if rank 0 not drained #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Once flux-framework/flux-core#5319 is fixed, broker ranks will not be drained if the epilog is running when a job is canceled. However, this causes t1024-alloc-check.t to fail since `flux resource undrain 0` will fail. Don't fail if the undrain of rank 0 fails, so that this test will pass even after fixing the flux-core bug.
Codecov Report
@@ Coverage Diff @@
## master #1047 +/- ##
========================================
- Coverage 74.4% 74.3% -0.1%
========================================
Files 86 86
Lines 9432 9432
========================================
- Hits 7020 7017 -3
- Misses 2412 2415 +3 |
|
Thanks, setting MWP. |
grondo
added
the
merge-when-passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Once flux-framework/flux-core#5319 is fixed, broker ranks will not be drained if the epilog is running when a job is canceled. However, this causes t1024-alloc-check.t to fail since
flux resource undrain 0will fail.Don't fail if the undrain of rank 0 fails, so that this test will pass even after fixing the flux-core bug.