flux-ion-resource: move to src/cmd and install #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, this should be good to go now I hope. It's notable that the first commit, the one that's a move and one line, is all it takes to install the script. The second commit is required for |
trws
force-pushed
the
install-flux-ion-resource
branch
from
c4b7b6d to
8159961
Compare
problem: recent production debugging and fixes have benefitted from having flux ion-resource available, but it is not installed. solution: install it, and since it's no longer a test-only script, move it to src/cmd/
problem: pylint is strict, and this script was never checked because it was in the test directory. solution: Commit all necessary sacrifices and rites to pylint the great and merciless.
trws
force-pushed
the
install-flux-ion-resource
branch
from
8159961 to
e4fd996
Compare
grondo
approved these changes
Dec 22, 2023
trws
added
the
merge-when-passing
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1127 +/- ##
======================================
Coverage 70.1% 70.1%
======================================
Files 90 90
Lines 12264 12264
======================================
Hits 8605 8605
Misses 3659 3659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: recent production debugging and fixes have benefitted from having flux ion-resource available, but it is not installed.
solution: install it, and since it's no longer a test-only script, move it to src/cmd/
fixes #1122