-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
traverser: allow non-exclusive slots #1194
Draft
jameshcorbett
wants to merge
1
commit into
flux-framework:master
Choose a base branch
from
jameshcorbett:non-exclusive-slots
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
traverser: allow non-exclusive slots #1194
jameshcorbett
wants to merge
1
commit into
flux-framework:master
from
jameshcorbett:non-exclusive-slots
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: putting a 'slot' entry in jobspec forces every entry below that to be exclusive or else the traverser will not consider them. If the 'slot' entry specifies 'exclusive: false', do not make slot matches exclusive. Otherwise maintain the old behavior of enforcing exclusivity.
8db824d
to
aa74436
Compare
With this PR, using this JGF graph and the version: 9999
resources:
- type: slot
count: 3
label: default
exclusive: false
with:
- type: ssd
count: 1
exclusive: true
- type: node
count: 1
with:
- type: slot
label: task
count: 1
with:
- type: core
count: 1
# a comment
attributes:
system:
duration: 3600
tasks:
- command: [ "app" ]
slot: task
count:
per_slot: 1 I was able to get non-exclusive matches:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1194 +/- ##
======================================
Coverage 73.9% 73.9%
======================================
Files 102 102
Lines 14595 14597 +2
======================================
+ Hits 10790 10792 +2
Misses 3805 3805
|
By comparison, keeping everything else constant but working off
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP as I try to get slots to work for matching rabbit resources.