Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade charts to Flux v2.4.0 release #229

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

czepiec
Copy link
Contributor

@czepiec czepiec commented Oct 2, 2024

What this PR does / why we need it:

Upgrade to Flux 2.4.0.

Which issue this PR fixes

Special notes for your reviewer:

  • Changes:
    • version in Makefile
    • artifacthub.io/changes
    • chart versions (flux2, flux2-notification, flux2-sync)
    • other changed by make
  • Tested on:
    • upgrade from previous
    • new release
  • To be sure, I compared the diff of commit with previous similar ones (to 2.2.3, to 2.3.0, etc.) and same files are changed in same way

We already use it on (not small) production infrastructure because we need Flux 2.4.0.

@stefanprodan I am glad to cooperate, probably in the future I will send some PR to discussion / overall improving of Helm chart.

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested
  • Update artifacthub.io/changes in Chart.yaml
  • Run make reviewable

@stefanprodan
Copy link
Member

@czepiec can you please add NotIn to the ignore list here:

ignore_words_list: iam,aks,keypair,re-use

@@ -16,6 +16,6 @@ jobs:
uses: codespell-project/actions-codespell@master
with:
skip: .git,./charts/flux2/Changelog.md,./charts/flux2-sync/Changelog.md
ignore_words_list: iam,aks,keypair,re-use
ignore_words_list: iam,aks,keypair,re-use,NotIn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @czepiec 🏅

@stefanprodan stefanprodan merged commit 08dcb08 into fluxcd-community:main Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants