Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Refer condition type constants from fluxcd/pkg/apis #1144

Merged
merged 1 commit into from
Apr 23, 2024
Merged

api: Refer condition type constants from fluxcd/pkg/apis #1144

merged 1 commit into from
Apr 23, 2024

Conversation

gdasson
Copy link
Contributor

@gdasson gdasson commented Apr 23, 2024 •
edited
Loading

With reference to this PR: fluxcd/pkg#723, I have referenced the kustomize constants from pkg now.

stefanprodan
stefanprodan reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the changes to v1beta1 and v1beta2, these API versions are considered readonly.

@gdasson
Copy link
Contributor Author

gdasson commented Apr 23, 2024

sure

@gdasson
Copy link
Contributor Author

gdasson commented Apr 23, 2024

@stefanprodan : fixed as suggested.

@stefanprodan stefanprodan added the area/api API related issues and pull requests label Apr 23, 2024
@stefanprodan stefanprodan changed the title Refer condition type constants from pkg api: Refer condition type constants from fluxcd/pkg/apis Apr 23, 2024
stefanprodan
stefanprodan approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @gdasson 🏅

@stefanprodan stefanprodan merged commit 3e512c5 into fluxcd:main Apr 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/api API related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdasson @stefanprodan