-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AWS STS endpoint in the Bucket API #1552
Conversation
2f84ddd
to
db23a9d
Compare
db23a9d
to
6b0d5b4
Compare
Back to draft, adding tests for proxy |
6b0d5b4
to
2d62c48
Compare
2d62c48
to
d0b6994
Compare
d0b6994
to
6ccf49f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @matheuscscp 🏅
6ccf49f
to
f692579
Compare
f692579
to
a85bae1
Compare
cd95833
to
4e5e838
Compare
4e5e838
to
099226d
Compare
e58988d
to
984f434
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the last few suggestions about tests, the implementation looks good to me.
The STS mock tests particularly look great.
23173e2
to
b036b69
Compare
b036b69
to
a01e1a6
Compare
Signed-off-by: Matheus Pimenta <[email protected]>
a01e1a6
to
7536ab4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some manual testing on EKS with IRSA.
- Without IRSA annotation, the bucket just failed due to no S3 permission.
- With IRSA annotation and no explicit STS config, just
.spec.provider: aws
, it worked. - With explicit STS endpoint
https://sts.amazonaws.com
, it worked. - Tried using a regional endpoint
https://sts.us-east-2.amazonaws.com
, it worked again. - Tried a non-existing endpoint
https://sts.us-east-5.amazonaws.com
, it resulted in errorPost \"https://sts.us-east-5.amazonaws.com\": dial tcp: lookup sts.us-east-5.amazonaws.com on 172.20.0.10:53: no such host
. - Tried a regional endpoint that's inactive in the account, resulted in error
No OpenIDConnect provider found in your account for <OIDC provider address>
. - Tried
http://sts.amazonaws.com
and it failed withconnection refused
error.
Everything looks good and as expected.
Thanks for all the work on this and being patience with me 🙂
Thanks for your excellent diligence, it keeps Flux being the best GitOps product out there! |
Fixes #1423
I was able to test this in my personal AWS account using both an interface endpoint and the public regional endpoints.