Skip to content

Update containerd v1.7.27 #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

Update containerd v1.7.27 #1812

merged 2 commits into from
May 27, 2025

Conversation

stefanprodan
Copy link
Member

@stefanprodan
Update containerd v1.7.27
36e0d0d 
Signed-off-by: Stefan Prodan <[email protected]>
@stefanprodan stefanprodan requested a review from matheuscscp May 27, 2025 06:17
@stefanprodan stefanprodan added the dependencies Pull requests that update a dependency label May 27, 2025
@stefanprodan
Copy link
Member Author

@matheuscscp in TestOCIRepository_objectLevelWorkloadIdentityFeatureGate we call update in a loop then we update again the same object so the test will randomly fail due to the update race.

--- FAIL: TestOCIRepository_objectLevelWorkloadIdentityFeatureGate (0.89s)
    ocirepository_controller_test.go:3073: 
        Expected success, but got an error:
            <*errors.StatusError | 0xc00a25dae0>: 
            Operation cannot be fulfilled on ocirepositories.source.toolkit.fluxcd.io "ocirepository-reconcileddpm8": the object has been modified; please apply your changes to the latest version and try again

@matheuscscp
Fix flaky test
71aa99e 
Signed-off-by: Matheus Pimenta <[email protected]>
@matheuscscp
Copy link
Member

@matheuscscp in TestOCIRepository_objectLevelWorkloadIdentityFeatureGate we call update in a loop then we update again the same object so the test will randomly fail due to the update race.

--- FAIL: TestOCIRepository_objectLevelWorkloadIdentityFeatureGate (0.89s)
    ocirepository_controller_test.go:3073: 
        Expected success, but got an error:
            <*errors.StatusError | 0xc00a25dae0>: 
            Operation cannot be fulfilled on ocirepositories.source.toolkit.fluxcd.io "ocirepository-reconcileddpm8": the object has been modified; please apply your changes to the latest version and try again

Yep I first noticed this in the helm 3.18 upgrade PR:

#1805 (comment)

https://github.com/fluxcd/source-controller/pull/1805/files#diff-4d0bfc777c67a80a5a394af0ffd62e1aec227c93bb10ed241a4ef4accaabedf2L3074

@matheuscscp matheuscscp merged commit fdc84c7 into main May 27, 2025
8 checks passed
@matheuscscp matheuscscp deleted the containerd-v1.7.27 branch May 27, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheuscscp matheuscscp matheuscscp approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @matheuscscp