Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terraform files to create Azure DevOps project and repository #44

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Add terraform files to create Azure DevOps project and repository #44

merged 1 commit into from
Aug 27, 2024

Conversation

dipti-pai
Copy link
Member

@dipti-pai dipti-pai commented Jul 15, 2024 •
edited
Loading

Terraform code to :

  • Take org id and pat as input
  • create project and repository
  • return repo url and project id as output

darkowlzz
darkowlzz reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

The CI checks failed due to formatting issues.
Please try running make tf-fmt from the project root to fix the formatting.

Also, let's add a README.md for this new module, similar to other modules.

tf-modules/azure/devops/main.tf Outdated Show resolved Hide resolved
tf-modules/azure/devops/versions.tf Outdated Show resolved Hide resolved
tf-modules/azure/devops/versions.tf Outdated Show resolved Hide resolved
tf-modules/azure/devops/main.tf Outdated Show resolved Hide resolved
@darkowlzz darkowlzz added the area/terraform Terraform related issues and pull requests label Jul 30, 2024
@darkowlzz
Copy link
Contributor

The changes here look good to me. I have left a suggestion in the README. Once that's resolved, please squash all the commits to a single commit.

@dipti-pai dipti-pai force-pushed the devops branch 4 times, most recently from a811922 to ad930a7 Compare August 27, 2024 05:45
darkowlzz
darkowlzz approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks.

@darkowlzz darkowlzz merged commit 3fa2bc4 into fluxcd:main Aug 27, 2024
2 checks passed
@dipti-pai dipti-pai mentioned this pull request Aug 28, 2024
Open
15 tasks
@dipti-pai dipti-pai mentioned this pull request Oct 2, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
area/terraform Terraform related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dipti-pai @darkowlzz