Update aws-codecommit.md #1523
Update aws-codecommit.md #1523
Conversation
|
@stefanprodan Please review |
| @@ -87,6 +87,24 @@ protocol](https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols#_the_ss | |||
| Use the [RFC 3986 compatible syntax](https://tools.ietf.org/html/rfc3986#section-3) instead: `git-codecommit.<region>.amazonaws.com/v1`. | |||
| {{% /alert %}} | |||
|
|
|||
| ## Create source from the CodeCommit | |||
There was a problem hiding this comment.
Maybe be more explicit?
| ## Create source from the CodeCommit | |
| ## Create GitRepository Source from CodeCommit Repository |
| 1. You need to create key manually upload that key to the IAM user. | ||
| 2. Make a note of the user ID for which you have uploaded the key | ||
| 3. When creating the source you need to specify the userid in the `Url`, `private-key-file` and `ssh-key-algorithm` |
There was a problem hiding this comment.
The installation section above shows how to use aws iam upload-ssh-public-key to upload ssh key. Maybe refer to that and follow the same names, instead of user ID, SSHPublicKeyID. The same placeholders can be used in the create source code snippet below.
There was a problem hiding this comment.
Also, since this is about ssh, how about adding another section about HTTP auth and how to get the IAM credentials for it?
| To create the source from Code-Commit run the following command: | ||
| ```sh | ||
| flux create source git flux-system \ | ||
| --git-implementation=libgit2 \ |
There was a problem hiding this comment.
Git implementation should no longer be needed.
|
|
||
| To create the source from Code-Commit run the following command: | ||
| ```sh | ||
| flux create source git flux-system \ |
There was a problem hiding this comment.
It's likely that flux-system GitRepository source already exists with the bootstrapped repository. Name use a placeholder instead of flux-system here.
| --private-key-file=./codecommit_rsa \ | ||
| --ssh-key-algorithm=rsa \ |
There was a problem hiding this comment.
Let's use placeholder here as well, similar to the placeholders in the installation section above.
Added info regarding creating source from the AWS CodeCommit