Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link checking - internal anchor references #1630

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Link checking - internal anchor references #1630

wants to merge 3 commits into from

Commits on Sep 7, 2023

  1. Test link-checker-gpt 

    This PR implements:

* https://github.com/kingdonb/link-checker-gpt/tree/v1-beta#integration-as-a-ci-check

I'm testing the new Dockerized version of the link-checker-gpt, that
helped us fix all the broken links in #1573

It should be possible to merge this if we are happy with it, independent
of the release for Flux v2.1 (it can certainly wait until after 👍)

I'm going to push a broken link as a test.

There has been some thought put into making a good workflow in a way
such that we don't want to 86 it right away... minor annoyances should
all be squashed prior to their annoying anyone

* add the workflow to .github/workflows

* fix the bug (upstream)

* provide GH_TOKEN to link checker
* (fix github token)

Signed-off-by: Kingdon Barrett <[email protected]>
    Kingdon Barrett committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    2fe8b0a View commit details
    Browse the repository at this point in the history

  2. This commit should fail 

    Add a bad link id anchor that doesn't go anywhere (but isn't a 404)

Signed-off-by: Kingdon Barrett <[email protected]>
    Kingdon Barrett committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    054e7b4 View commit details
    Browse the repository at this point in the history

  3. Revert "This commit should fail" 

    This reverts commit 6ffc756.

Signed-off-by: Kingdon Barrett <[email protected]>
    Kingdon Barrett committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    54ab90f View commit details
    Browse the repository at this point in the history