Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark chart.spec.version as specific to HelmRepository source in example #709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Mark chart.spec.version as specific to HelmRepository source in example #709

wants to merge 1 commit into from

Commits on Jan 20, 2022

  1. mark chart.spec.version as specific to HelmRepository source in example 

    In my opinion it is not visible enough that `chart.spec.version` is only considered for `HelmRepository` sources (and silently ignored otherwise.
I'm aware that the text below the example mentions this, but I think it would be benefitial for the code example itself to make that fact clear.

Adding this comment is only a suggestion (which I'm not 100% happy with myself) -- feel free to substitute a different way of pointing out the connection between `HelmRepository` and the version spec.

Signed-off-by: Tom Janson <[email protected]>
    @tjanson
    tjanson committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    0ec1751 View commit details
    Browse the repository at this point in the history