Remove asset build stage when no package.json exists #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KTanAug21
deleted the
remove_node_installation_if_node_config_not_available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and Why:
Remove the asset build stage from the generated Dockerfile when package.json does not exist. This build stage results in build error for Laravel apps that don't use package.json, i.e. api apps. See community member issue here!
How:
Set the value of option['build-asset'] to false if no package.json exists!
Also:
Quick edit to the GenerateCommandTest.php to include package.json file in each supported test folder, so that the asset build stage is included in the generated dockerfiles during testing.