Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pfd-briefing): alternative solution to content tabs #932

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

Valastiri
Copy link
Member

@Valastiri Valastiri commented Jan 19, 2024

Summary

As indicated in our docs channel content tabs were not working due to a limitation of the theme.

We could either pull it apart and customize it or just change our implementation.

Suggested in PR is using the new card grid feature to split the elements into two groups. Removing the TOC also helps spread out the page and layout. Additional options are welcome.

We've gotten rid of the below and transitioned this into bullet points instead. Just to keep this page relatively simple as it's the only content on the page.

Option 1:
<img width="1407" alt="image" src="https://github.com/flybywiresim/docs/assets/1619968/2508b618-b569-47a0-b31c-ae5f790c181b">


Option 2: instead of `card grids` is just two simple admonitions:
<img width="1584" alt="image" src="https://github.com/flybywiresim/docs/assets/1619968/49fe7b85-b96a-4522-baea-0603dd5f3135">

Location

  • docs/pilots-corner/a32nx-briefing/pfd/flags-messages.md

Discord username (if different from GitHub): valastiri

Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 5:57pm

@Valastiri Valastiri marked this pull request as ready for review January 19, 2024 17:56
@github-actions github-actions bot added the Review Required PR Check Label label Jan 19, 2024
@github-actions github-actions bot removed the Review Required PR Check Label label Jan 22, 2024
@github-actions github-actions bot merged commit 4be88b8 into flybywiresim:primary Jan 22, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant