Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flypad-settings): Move Simbrief Import section & introduce navigraph section #946

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

alepouna
Copy link
Member

@alepouna alepouna commented Mar 4, 2024

Summary

Moves the Simbrief Import description from ATSU/AOC to 3rd Party Settings, as it is being moved with flybywiresim/aircraft#8548.

This PR also introduces a section for Navigraph in the '3rd Party Settings' as it was missing. Please add reviews for the text, as I am not sure how correct it is in terms of grammar and sense.

I am also attaching here my screenshots for replacement in settings.md Lines 223 & 265 but I am unsure if they are fine, LMK.

FlightSimulator_nj5Hm5gSVd
FlightSimulator_TWiUTRO3iK

Location

docs/fbw-a32nx/feature-guides/flypados3/settings.md

https://docs-git-fork-alepouna-aircraft-8548-flybywire.vercel.app/fbw-a32nx/feature-guides/flypados3/settings

Discord username (if different from GitHub): alepouna

Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2024 6:33am

Copy link

github-actions bot commented Mar 4, 2024

This PR is being prevented from merging because Review Required. Use the Approved label to run build validation and auto merge the PR.

Copy link
Member

@Valastiri Valastiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be prudent to double check the SimBrief integration page here https://docs.flybywiresim.com/fbw-a32nx/feature-guides/simbrief/#setup-a32nx-simbrief-integration

Since it's a dedicated page and the flypad is more of a brief overview of the features shown on a page.

Your images are fine just make sure to optimize them for the web. Thanks for this!

docs/fbw-a32nx/feature-guides/flypados3/settings.md Outdated Show resolved Hide resolved
docs/fbw-a32nx/feature-guides/flypados3/settings.md Outdated Show resolved Hide resolved
docs/fbw-a32nx/feature-guides/flypados3/settings.md Outdated Show resolved Hide resolved
docs/fbw-a32nx/feature-guides/flypados3/settings.md Outdated Show resolved Hide resolved
@alepouna
Copy link
Member Author

Review comments added, I will optimize the images and upload them. Thanks @Valastiri & @Sleinmaster

@Valastiri
Copy link
Member

Valastiri commented Mar 15, 2024

@2hwk I'm a little confused why a review is requested when the A32NX PR is on do not merge. Please advise here or feel free ping me in Discord :)

Edit: This PR is also missing images cc: @alepouna

@2hwk
Copy link
Member

2hwk commented Mar 15, 2024

@2hwk I'm a little confused why a review is requested when the A32NX PR is on do not merge. Please advise here or feel free ping me in Discord :)

Edit: This PR is also missing images cc: @alepouna

I think I meant to hit dismiss review not re-request, my bad

@Valastiri
Copy link
Member

Affirm thanks!

@alepouna
Copy link
Member Author

Edit: This PR is also missing images cc: @alepouna

Images updated to an optimized version of those found in the PR description.

@2hwk 2hwk merged commit 7da159c into flybywiresim:primary Apr 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature guide Review Required PR Check Label waiting on a32nx PR PRs waiting for the corresponding a32nx repo PR to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants