feat: remote displays app and PR CI #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjozork
changed the title
alepouna
reviewed
Apr 1, 2024
| let remoteClient: RemoteClient | undefined; | ||
| function initializeClient() { | ||
| if (!remoteClient) { | ||
| remoteClient = new RemoteClient(`ws://${window.location.hostname}:8380/interfaces/v1/remote-app`); |
There was a problem hiding this comment.
remoteClient = new RemoteClient(
ws://${window.location.hostname}:8380/interfaces/v1/remote-app);
Wouldn't it better to use the configured server port incase user has a different port set via the installer?
2hwk
requested changes
Apr 2, 2024
Comment on lines
-1
to
+17
| name: PR | ||
| on: | ||
| pull_request_target: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| - ready_for_review | ||
|
|
||
| jobs: | ||
| title: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: amannn/[email protected] | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| name: PR | ||
| on: | ||
| pull_request_target: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| - ready_for_review | ||
|
|
||
| jobs: | ||
| title: | ||
| name: Validate title semantics | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: amannn/[email protected] | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
diff here? is this just whitespace?
| onChange={(event) => setTypedBridgeID(event.target.value)} | ||
| /> | ||
|
|
||
| <span>GFNCBENFB4TQ</span> |
There was a problem hiding this comment.
Suggested change
| <span>GFNCBENFB4TQ</span> | |
| <span>GFNCBENFB4TQ</span> |
Does this have a purpose? Or is this meant to be taken from a var somewhere? I'm not very sure.
alepouna
reviewed
Apr 3, 2024
| this.server = server; | ||
| this.logger.log('Remote app gateway websocket initialised'); | ||
| this.logger.log( | ||
| `Initialised on http://${await this.networkService.getLocalIp(true)}:${this.serverConf.port}${server.path}`, |
There was a problem hiding this comment.
Suggested change
| `Initialised on http://${await this.networkService.getLocalIp(true)}:${this.serverConf.port}${server.path}`, | |
| `Initialised websocket gateway on ws://${await this.networkService.getLocalIp(true)}:${this.serverConf.port}${server.path}`, |
I believe that a user looking at the logs might think this is (also) the remote app path and try to access it but of course it returns 404 since its only for websockets, and might cause confusion.
alepouna
reviewed
Apr 3, 2024
| ? `Connected (${connectionState.clientName})` | ||
| : connectionState.connected === ConnectionPhase.ConnectedToBridge | ||
| ? 'Waiting on aircraft' | ||
| : 'Not connected'} |
There was a problem hiding this comment.
Suggested change
| : 'Not connected'} | |
| : 'Simbridge Connection Lost'} |
Benjozork
force-pushed
the
feature/remote-app
branch
from
4acfc5d to
e6d613e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.