fix: add folder fallback to prevent app crash #135
Merged
+9
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maximilian-Reuter
approved these changes
Nov 13, 2024
Shaddowpain
approved these changes
Nov 13, 2024
alepouna
approved these changes
Nov 13, 2024
|
|
||
| export const getSimbridgeDir = () => { | ||
| try { | ||
| return path.join(getPath('documents'), 'FlyByWireSim', 'Simbridge'); | ||
| } catch (e) { | ||
| Logger.warn('Could not get documents path via WinAPI, trying alternate method', e); | ||
| Logger.warn( | ||
| 'Could not get documents path via WinAPI, Windows Controlled Folder Access is likely blocking the app. Using AppData as fallback', |
There was a problem hiding this comment.
Could we note here a documentation link to either MS or our docs for how to override WCFA if someone wants to do this? Note as a comment on the code, not the log message FYI.
There was a problem hiding this comment.
Do we need this ? No user is gonna look in the code and as a dev one should be able to use google :D Especially since that link will likely eventually go stale and will need updating. If anything I would suggest making a bot command for support that links to the relevant MS docs.
There was a problem hiding this comment.
Also the console closes by default so only who either disabled the setting or opens it manually will see the error message. Bot command sounds fine to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Windows Controlled Folder access is enabled, it will prevent simbridge from accessing the documents folder and the app will crash. Added a fallback to use the appdata directory, which is not protected by default.
Note: the old workaround via powershell was removed, as the reason for platform-folders to fail was Windows blocking it as well. So it's not needed anymore IMO.
Fixes #134
Fixes #133
Fixes #130