-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.11] Initial platform support for layer-3 routed networks (L3-VNI) #1246
base: fc-24.11-dev
Are you sure you want to change the base?
Conversation
fa1ed52
to
3e97c8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should review this together - I can't quite follow all the code and have the impression that we might want to pay attention to comments and factoring to keep it readable/understandable for the future us's.
nixos/platform/network.nix
Outdated
# the routing tables 0, 253, 254, and 255 are reserved by the | ||
# kernel. this base number is chosen as an arbitrary offset for | ||
# numbering kernel routing tables for vrfs | ||
tableBase = 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HMMM! This is interesting, we should check back with our vlan/vxlan/... numbering scheme and whether that can fit without shifting the values ...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not a bad idea actually. We definitely have space in the numbering scheme as it stands at present, so we could reserve those four IDs and then map the virtual network ID one-to-one to kernel tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. add assertions and update the docs.
PL-133324
Add a new ENC flag to indicate whether an interface should be moved to a separate VRF, and create and manage the VRF devices accordingly. This logic is only applied for VXLAN interfaces. PL-133324
aad6b6e
to
ee6bd8b
Compare
This change adds initial support for using EVPN-VXLAN as a transport for layer 3 routed-to-the-host networking. Networks which have the
layer3
flag set in the ENC data will have an additional VRF device will be created which will be configured as the parent interface for other devices associated with that network (bridge device, VXLAN device).PL-133324
@flyingcircusio/release-managers
Release process
./changelog.sh
PR release workflow (internal)
Design notes
on
oroff
. Example: rate limiting.Security implications