Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.11] Initial platform support for layer-3 routed networks (L3-VNI) #1246

Open
wants to merge 5 commits into
base: fc-24.11-dev
Choose a base branch
from

Conversation

sysvinit
Copy link
Member

@sysvinit sysvinit commented Jan 22, 2025

This change adds initial support for using EVPN-VXLAN as a transport for layer 3 routed-to-the-host networking. Networks which have the layer3 flag set in the ENC data will have an additional VRF device will be created which will be configured as the parent interface for other devices associated with that network (bridge device, VXLAN device).

PL-133324

@flyingcircusio/release-managers

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • This is a initial preview for a new feature, however this is gated behind an ENC flag which is currently not implemented in the directory. Merging this should not cause any changes in behaviour on existing hosts.
  • Security requirements tested? (EVIDENCE)
    • Tested on various hardware hosts in DEV.

@sysvinit sysvinit force-pushed the PL-133324-routed-fe-platform branch from fa1ed52 to 3e97c8a Compare January 22, 2025 14:44
@sysvinit sysvinit marked this pull request as ready for review January 22, 2025 14:57
@sysvinit sysvinit requested a review from ctheune January 22, 2025 14:57
Copy link
Member

@ctheune ctheune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should review this together - I can't quite follow all the code and have the impression that we might want to pay attention to comments and factoring to keep it readable/understandable for the future us's.

# the routing tables 0, 253, 254, and 255 are reserved by the
# kernel. this base number is chosen as an arbitrary offset for
# numbering kernel routing tables for vrfs
tableBase = 1000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HMMM! This is interesting, we should check back with our vlan/vxlan/... numbering scheme and whether that can fit without shifting the values ...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a bad idea actually. We definitely have space in the numbering scheme as it stands at present, so we could reserve those four IDs and then map the virtual network ID one-to-one to kernel tables.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. add assertions and update the docs.

sysvinit and others added 5 commits January 30, 2025 11:58
Add a new ENC flag to indicate whether an interface should be moved to
a separate VRF, and create and manage the VRF devices
accordingly. This logic is only applied for VXLAN interfaces.

PL-133324
@sysvinit sysvinit force-pushed the PL-133324-routed-fe-platform branch from aad6b6e to ee6bd8b Compare January 30, 2025 10:59
@sysvinit sysvinit requested a review from ctheune January 30, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants