-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PL-133028] alloy configuration for the mysql slow log #1269
base: fc-24.11-dev
Are you sure you want to change the base?
Conversation
6e9555f
to
cb217b7
Compare
|
||
### NixOS XX.XX platform | ||
|
||
- Add configuration for alloy that exports MySQL's slow logs to loki if configured for the resource group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been writing changelogs for Loki-related platform features given that the integration is still considered WIP. But if you do leave it in, adding a ticket number would be nice.
@@ -10,6 +10,7 @@ let | |||
fclib = config.fclib; | |||
supportedPerconaVersions = ["8.0" "8.3" "8.4"]; | |||
removeDot = builtins.replaceStrings ["."] [""]; | |||
lokiServer = fclib.findOneService "loki-collector"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an implementation detail which shouldn't need to be visible for roles which provide Alloy/Loki integration, but that's something we can solve separately later.
nixos/roles/mysql.nix
Outdated
forward_to = [loki.write.fcio_rg_loki.receiver] | ||
|
||
stage.multiline { | ||
firstline = "^# Time: (?P<time>.+?)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there's multiple "weird" whitespace choices here ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah fair, I just copied the bulk of this from what alloy generated for the previous prometheus config and removed some fields that were not required or straight up caused issues when attempting to run it
cb217b7
to
1b071d6
Compare
@flyingcircusio/release-managers
PL-133028
based on #1264
Release process
./changelog.sh
PR release workflow (internal)
Design notes
on
oroff
. Example: rate limiting.Security implications