Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] nixos/platform: use nix.settings for connect-timeout #1276

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented Feb 6, 2025

backport of #1274

PL-133327

As discussed, it might be useful to have some kind of feature-flag for the connect-timeout since modifying declarations of nix.extraOptions is hard.

Instead, decided to just use nix.settings here, that way the timeout can be adjusted with primitives of the module system and without an additional option.

@flyingcircusio/release-managers

Release process

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

PL-133327

As discussed, it might be useful to have some kind of feature-flag for
the connect-timeout since modifying declarations of `nix.extraOptions`
is hard.

Instead, decided to just use `nix.settings` here, that way the timeout
can be adjusted with primitives of the module system and without an
additional option.
@osnyx osnyx merged commit 87a835c into fc-23.11-dev Feb 6, 2025
2 checks passed
@osnyx osnyx deleted the PL-133327-2311-bp branch February 6, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants