[23.11] nixos/platform: use nix.settings
for connect-timeout
#1276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1274
PL-133327
As discussed, it might be useful to have some kind of feature-flag for the connect-timeout since modifying declarations of
nix.extraOptions
is hard.Instead, decided to just use
nix.settings
here, that way the timeout can be adjusted with primitives of the module system and without an additional option.@flyingcircusio/release-managers
Release process
./changelog.sh
: Followup for [PL-133327] nixos/platform: set Nix's connect-timeout to 1s #1256, no behavioral change.PR release workflow (internal)
Design notes
on
oroff
. Example: rate limiting.Security implications
nix.settings
for connect-timeout #1274, no behavioural changes