Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fc.agent.s3users: add timeouts, silence errors after user was deleted, monitoring #1289

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

leona-ya
Copy link
Member

@leona-ya leona-ya commented Feb 17, 2025

PL-133447

@flyingcircusio/release-managers

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • Timeouts could forcefully end a good execution of the program. This shouldn't happen in any of our DCs
    • Timeouts + silencing should be effective
    • Monitoring should work
  • Security requirements tested? (EVIDENCE)
    • In our largest RGW cluster the script currently runs <1min. With our normal monitoring procedures, we already ensure that we would detect a failed systemd unit (timed-out units are in the failed status)
    • Tested timeouts (added a sleep to the script) + silencing
    • Tested monitoring in dev

@leona-ya leona-ya changed the title fc.agent.s3users: add timeouts, silence errors after user was deleted fc.agent.s3users: add timeouts, silence errors after user was deleted, monitoring Feb 19, 2025
@osnyx osnyx merged commit 16d21f3 into fc-24.11-dev Feb 20, 2025
2 checks passed
@osnyx osnyx deleted the PL-133447-s3-management-improvements branch February 20, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants