Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "matomo: fix quoting in cleanup shell script" #1301

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented Feb 20, 2025

This reverts commit 861912f from #1279. The commit was intended for the fc-24.11-dev branch, as matomo4 might still play a role here in 24.05.

The list of files to be removed is the list for matomo5 after an upgrade.

@flyingcircusio/release-managers

PL-133012

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • undoes a change that went to the incorrect branch
    • change was never released so far, no customer impact of the revert.
  • Security requirements tested? (EVIDENCE)
    • automated tests still pass

This reverts commit 861912f.
The commit was intended for the fc-24.11-dev branch, as matomo4 might
still play a role here.
@ctheune ctheune merged commit 78390de into fc-24.05-dev Feb 27, 2025
2 checks passed
@ctheune ctheune deleted the PL-133012-revert-2405 branch February 27, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants