Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/router: remove superfluous assertions #1317

Open
wants to merge 1 commit into
base: fc-24.11-dev
Choose a base branch
from

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented Mar 3, 2025

Follow-up of #1312.

According to @ctheune, there is no need to be alerted through an assertion when test harness interface naming logic changes. Other tests implicitly already sufficiently cover wrong interface naming consequences.

@flyingcircusio/release-managers

PL-133497

Release process

  • Created changelog entry using ./changelog.sh
    • completely internal follow-up to change that has not been released yet

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • None, removal of a superfluous VM test assertion
  • Security requirements tested? (EVIDENCE)

According to @ctheune, there is no need to be alerted through an
assertion when test harness interface naming logic changes. Other tests
implicitly already sufficiently cover wrong interface naming
consequences.
@osnyx osnyx added risk: 1 very low risk urgency: 1 very low urgency labels Mar 10, 2025
Copy link

This PR is ready to merge. Merge scheduled for 2025-03-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
risk: 1 very low risk urgency: 1 very low urgency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants