Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce slurm memory limits #900

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

zagy
Copy link
Member

@zagy zagy commented Jan 30, 2024

(maybe this should be configurable …)

FC-35724
PL-132161

@flyingcircusio/release-managers

Release process

Impact:

Changelog:

  • slurm: use task/cgroup to enforce memory limits on jobs (PL-132161, FC-35724).

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Security implications

  • Security requirements defined? (WHERE)
    • enforce memory limits for user-run slurm job to avoid nodes being unresponsive due to memory pressure/swapping
  • Security requirements tested? (EVIDENCE)
    • checked on slurm test cluster that jobs can be run with the new setting

(maybe this should be configurable …)

FC-35724
@dpausp dpausp merged commit 0a9a6ad into fc-23.11-dev Feb 1, 2024
2 checks passed
@dpausp dpausp deleted the PL-132161-FC-35724-slurm-limit branch February 1, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants