Skip to content

Commit

Permalink
Flyte-core flyteadmin / datacatalog expose ports
Browse files Browse the repository at this point in the history
 - Both flyteadmin and datacatalog have configurable ports to use for
   HTTP and GRPC, but the k8s spec for the containers doesn't expose
   matching ports.

   Fix that!

Signed-off-by: ddl-ebrown <[email protected]>
  • Loading branch information
ddl-ebrown committed Mar 6, 2024
1 parent ba59258 commit 03c79e0
Show file tree
Hide file tree
Showing 11 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions charts/flyte-core/templates/admin/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ spec:
imagePullPolicy: "{{ .Values.flyteadmin.image.pullPolicy }}"
name: flyteadmin
ports:
- containerPort: 8088
- containerPort: 8089
- containerPort: {{ .Values.configmap.adminServer.server.httpPort }}
- containerPort: {{ .Values.configmap.adminServer.server.grpcPort }}
- containerPort: {{ .Values.configmap.adminServer.flyteadmin.profilerPort }}
readinessProbe:
exec:
Expand Down
4 changes: 2 additions & 2 deletions charts/flyte-core/templates/datacatalog/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ spec:
imagePullPolicy: "{{ .Values.datacatalog.image.pullPolicy }}"
name: datacatalog
ports:
- containerPort: 8088
- containerPort: 8089
- containerPort: {{ .Values.configmap.datacatalogServer.application.httpPort }}
- containerPort: {{ .Values.configmap.datacatalogServer.application.grpcPort }}
- containerPort: {{ index .Values.configmap.datacatalogServer.datacatalog "profiler-port" }}
securityContext:
allowPrivilegeEscalation: false
Expand Down
2 changes: 1 addition & 1 deletion deployment/eks/flyte_aws_scheduler_helm_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ spec:
imagePullPolicy: "IfNotPresent"
name: datacatalog
ports:
- containerPort: 8088
- containerPort: 8080
- containerPort: 8089
- containerPort: 10254
securityContext:
Expand Down
2 changes: 1 addition & 1 deletion deployment/eks/flyte_helm_controlplane_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,7 @@ spec:
imagePullPolicy: "IfNotPresent"
name: datacatalog
ports:
- containerPort: 8088
- containerPort: 8080
- containerPort: 8089
- containerPort: 10254
securityContext:
Expand Down
2 changes: 1 addition & 1 deletion deployment/eks/flyte_helm_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1239,7 +1239,7 @@ spec:
imagePullPolicy: "IfNotPresent"
name: datacatalog
ports:
- containerPort: 8088
- containerPort: 8080
- containerPort: 8089
- containerPort: 10254
securityContext:
Expand Down
2 changes: 1 addition & 1 deletion deployment/gcp/flyte_helm_controlplane_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,7 @@ spec:
imagePullPolicy: "IfNotPresent"
name: datacatalog
ports:
- containerPort: 8088
- containerPort: 8080
- containerPort: 8089
- containerPort: 10254
securityContext:
Expand Down
2 changes: 1 addition & 1 deletion deployment/gcp/flyte_helm_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,7 @@ spec:
imagePullPolicy: "IfNotPresent"
name: datacatalog
ports:
- containerPort: 8088
- containerPort: 8080
- containerPort: 8089
- containerPort: 10254
securityContext:
Expand Down
2 changes: 1 addition & 1 deletion deployment/sandbox/flyte_helm_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7026,7 +7026,7 @@ spec:
imagePullPolicy: "IfNotPresent"
name: datacatalog
ports:
- containerPort: 8088
- containerPort: 8080
- containerPort: 8089
- containerPort: 10254
securityContext:
Expand Down
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/complete-agent.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ type: Opaque
---
apiVersion: v1
data:
haSharedSecret: YXFGVndTaXBySjFxWEIxNA==
haSharedSecret: TG9OU3R3VjhUWVl1N0RSVQ==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -1412,7 +1412,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: f5132fa475eb2386265cbda64d4e6d56922b771a5f7f5e6e8e4536a712663e45
checksum/secret: 596d932561c0727baaf2d4b818bfa9ebdc9bdbc021470c467229e15ecb9f11a9
labels:
app: docker-registry
release: flyte-sandbox
Expand Down
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/complete.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ type: Opaque
---
apiVersion: v1
data:
haSharedSecret: QVo4T0pQZmZLcFZmNjIyNQ==
haSharedSecret: ZHZlR2liVzdRM0hEREZKTQ==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -1360,7 +1360,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: f5e2b9fbf28a7d7815a094f72366cac395bd0aacd7890faa07e80ec700770fc5
checksum/secret: ede3e3f0b09a73cf6747e615c4032c8157737f895808b98d4d793cd6bfe5f730
labels:
app: docker-registry
release: flyte-sandbox
Expand Down
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ metadata:
---
apiVersion: v1
data:
haSharedSecret: dktYanZDU0tsa0hTWlZmWA==
haSharedSecret: bmc4R1hFYjVyT2c5SFNESg==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -934,7 +934,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: 7956909ef2268e1aad9b4b132d938c8b1a5775321bacfaf61aea7b73cdbcc85e
checksum/secret: 25041a2a7bfc095be829b14e1e9fc84ecf740ea76d122cb8dbace5f759f4532b
labels:
app: docker-registry
release: flyte-sandbox
Expand Down

0 comments on commit 03c79e0

Please sign in to comment.