add metadata message in idl

add metadata in updateartifact request in propeller

change in catalog

add test

Signed-off-by: Yue Shang <[email protected]>

datacatalog/pkg/manager/impl/artifact_manager.go

@@ -332,6 +332,16 @@ func (m *artifactManager) UpdateArtifact(ctx context.Context, request *datacatal
 		return nil, err
 	}
 
+	// artifactModel needs to be updated with new SerializedMetadata
+	serializedMetadata, err := transformers.SerializedMetadata(request.Metadata)
+	if err != nil {
+		logger.Errorf(ctx, "Error in transforming Metadata from request %+v, err %v", request.Metadata, err)
+		m.systemMetrics.transformerErrorCounter.Inc(ctx)
+		m.systemMetrics.updateFailureCounter.Inc(ctx)
+		return nil, err
+	}
+	artifactModel.SerializedMetadata = serializedMetadata
+
 	artifact, err := transformers.FromArtifactModel(artifactModel)
 	if err != nil {
 		logger.Errorf(ctx, "Error in transforming update artifact request %+v, err %v", artifactModel, err)
@@ -369,6 +379,10 @@ func (m *artifactManager) UpdateArtifact(ctx context.Context, request *datacatal
 
 	// update artifact in DB, also replaces/upserts associated artifact data
 	artifactModel.ArtifactData = artifactDataModels
+	logger.Infof(ctx, "ArtifactModel is %+v", artifactModel)
+	logger.Infof(ctx, "ArtifactModel ArtifactData is %+v", artifactModel.ArtifactData)
+	logger.Infof(ctx, "ArtifactModel SerializedMetadata is %+v", artifactModel.SerializedMetadata)
+
 	err = m.repo.ArtifactRepo().Update(ctx, artifactModel)
 	if err != nil {
 		if errors.IsDoesNotExistError(err) {

datacatalog/pkg/repositories/transformers/artifact.go

@@ -9,6 +9,14 @@ import (
 	"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/datacatalog"
 )
 
+func SerializedMetadata(metadata *datacatalog.Metadata) ([]byte, error) {
+	serializedMetadata, err := marshalMetadata(metadata)
+	if err != nil {
+		return []byte{}, err
+	}
+	return serializedMetadata, nil
+}
+
 func CreateArtifactModel(request *datacatalog.CreateArtifactRequest, artifactData []models.ArtifactData, dataset models.Dataset) (models.Artifact, error) {
 	datasetID := request.Artifact.Dataset
 

datacatalog/pkg/repositories/transformers/artifact_test.go

@@ -12,6 +12,12 @@ import (
 	"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/datacatalog"
 )
 
+func TestSerializedMetadata(t *testing.T) {
+	serializedMetadata, err := SerializedMetadata(metadata)
+	assert.IsType(t, []byte{}, serializedMetadata)
+	assert.NoError(t, err)
+}
+
 func getTestArtifactData() []*datacatalog.ArtifactData {
 	testInteger := &core.Literal{
 		Value: &core.Literal_Scalar{