remove type

Signed-off-by: pmahindrakar-oss <[email protected]>

flyteidl/clients/go/coreutils/extract_literal_test.go

@@ -202,25 +202,24 @@ func TestFetchLiteral(t *testing.T) {
 
 	t.Run("Offloaded metadata", func(t *testing.T) {
 		literalVal := "s3://blah/blah/blah"
-		var literalType = &core.LiteralType{
-			Type: &core.LiteralType_OffloadedType{
-				OffloadedType: &core.OffloadedType{
-					ActualLiteralType: &core.LiteralType{
-						Type: &core.LiteralType_CollectionType{
-							CollectionType: &core.LiteralType{
-								Type: &core.LiteralType_Simple{
-									Simple: core.SimpleType_INTEGER,
-								},
-							},
-						},
+		var storedLiteralType = &core.LiteralType{
+			Type: &core.LiteralType_CollectionType{
+				CollectionType: &core.LiteralType{
+					Type: &core.LiteralType_Simple{
+						Simple: core.SimpleType_INTEGER,
 					},
 				},
 			},
 		}
-		lit, err := MakeLiteralForType(literalType, literalVal)
-
-		assert.NoError(t, err)
-		extractedLiteralVal, err := ExtractFromLiteral(lit)
+		offloadedLiteral := &core.Literal{
+			Value: &core.Literal_OffloadedMetadata{
+				OffloadedMetadata: &core.LiteralOffloadedMetadata{
+					Uri:          literalVal,
+					InferredType: storedLiteralType,
+				},
+			},
+		}
+		extractedLiteralVal, err := ExtractFromLiteral(offloadedLiteral)
 		assert.NoError(t, err)
 		assert.Equal(t, literalVal, extractedLiteralVal)
 	})

flyteidl/clients/go/coreutils/literals.go

@@ -636,14 +636,6 @@ func MakeLiteralForType(t *core.LiteralType, v interface{}) (*core.Literal, erro
 		if !found {
 			return nil, fmt.Errorf("incorrect union value [%s], supported values %+v", v, newT.UnionType.Variants)
 		}
-	case *core.LiteralType_OffloadedType:
-		// This is a special type that is used to represent a literal that is offloaded to a remote store.
-		// The value here is the URI of the offloaded data.
-		l.Value = &core.Literal_OffloadedMetadata{
-			OffloadedMetadata: &core.LiteralOffloadedMetadata{
-				Uri: fmt.Sprintf("%v", v),
-			},
-		}
 	default:
 		return nil, fmt.Errorf("unsupported type %s", t.String())
 	}